Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS entity agent attributes to DynamoDB spans #1252

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Nov 13, 2024

Overview

Add AWS entity agent attributes to DynamoDB spans. See implementation_guides/aws-sdk.md in agent specs for details.
Note this is dependent on #1249.

@hmstepanek hmstepanek requested a review from a team as a code owner November 13, 2024 00:50
Copy link

github-actions bot commented Nov 13, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.01s
✅ PYTHON black 3 0 0 1.19s
✅ PYTHON flake8 3 0 0.64s
✅ PYTHON isort 3 0 0 0.31s
✅ PYTHON pylint 3 0 4.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 44.11765% with 38 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (bec0279) to head (1475665).

Files with missing lines Patch % Lines
newrelic/hooks/external_botocore.py 44.11% 24 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   81.29%   81.09%   -0.20%     
==========================================
  Files         200      200              
  Lines       22021    22088      +67     
  Branches     3488     3508      +20     
==========================================
+ Hits        17902    17913      +11     
- Misses       2967     3009      +42     
- Partials     1152     1166      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

newrelic/hooks/external_botocore.py Dismissed Show dismissed Hide dismissed
TimPansino
TimPansino previously approved these changes Nov 21, 2024
@hmstepanek hmstepanek dismissed TimPansino’s stale review November 22, 2024 19:05

The merge-base changed after approval.

@hmstepanek hmstepanek merged commit 4853f32 into main Nov 26, 2024
55 of 56 checks passed
@hmstepanek hmstepanek deleted the add-aws-entity-dynamodb branch November 26, 2024 01:37
@mergify mergify bot removed the tests-failing label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants