Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiomysql Instrumentation #1265

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

aiomysql Instrumentation #1265

wants to merge 9 commits into from

Conversation

TimPansino
Copy link
Contributor

Overview

  • Add instrumentation and tests for aiomysql.

@TimPansino TimPansino requested a review from a team as a code owner November 26, 2024 20:09
Copy link

github-actions bot commented Nov 26, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.24s
✅ PYTHON black 4 0 0 2.01s
✅ PYTHON flake8 4 0 1.08s
✅ PYTHON isort 4 0 0 0.23s
✅ PYTHON pylint 4 0 6.47s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (583b144) to head (0e5100b).

Files with missing lines Patch % Lines
newrelic/hooks/database_aiomysql.py 95.55% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
+ Coverage   79.45%   79.52%   +0.06%     
==========================================
  Files         200      201       +1     
  Lines       22126    22173      +47     
  Branches     3517     3519       +2     
==========================================
+ Hits        17581    17633      +52     
+ Misses       3388     3380       -8     
- Partials     1157     1160       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label Nov 27, 2024
@mergify mergify bot added the tests-failing label Dec 4, 2024
hmstepanek
hmstepanek previously approved these changes Dec 5, 2024
@hmstepanek
Copy link
Contributor

Looks like there's a couple lint issues to be fixed before merging but already pre-approved:

  newrelic/hooks/database_aiomysql.py:28:1: W293 blank line contains whitespace
  newrelic/hooks/database_aiomysql.py:42:1: W293 blank line contains whitespace
  newrelic/hooks/database_aiomysql.py:62:25: E272 multiple spaces before keyword
  newrelic/hooks/database_aiomysql.py:62:25: E222 multiple spaces after operator

hmstepanek
hmstepanek previously approved these changes Dec 9, 2024
@hmstepanek hmstepanek enabled auto-merge December 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants