Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pathlike objects not accepted by newrelic.initialize() #1268

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

TimPansino
Copy link
Contributor

Overview

  • Fixes bug where only str is accepted by newrelic.initialize() after update and not all pathlib.Pathlike object types (str, bytes, PosixPath, etc.).

Related Github Issue

Fixes #1267

@TimPansino TimPansino requested a review from a team as a code owner December 3, 2024 18:47
Copy link

github-actions bot commented Dec 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 6.61s
✅ PYTHON black 2 0 0 2.19s
✅ PYTHON flake8 2 0 1.23s
✅ PYTHON isort 2 0 0 0.24s
✅ PYTHON pylint 2 0 7.77s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (4853f32) to head (64df833).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   81.20%   81.19%   -0.02%     
==========================================
  Files         200      200              
  Lines       22088    22089       +1     
  Branches     3508     3508              
==========================================
- Hits        17937    17935       -2     
- Misses       2989     2990       +1     
- Partials     1162     1164       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek hmstepanek merged commit 956e8bc into main Dec 4, 2024
52 of 56 checks passed
@hmstepanek hmstepanek deleted the fix-configfile-pathobj branch December 4, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent could not initialize properly
3 participants