Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HTTP headers with all Transactions #1029

Closed
jamesarosen opened this issue Mar 16, 2022 · 8 comments · Fixed by #2155
Closed

Include HTTP headers with all Transactions #1029

jamesarosen opened this issue Mar 16, 2022 · 8 comments · Fixed by #2155
Assignees
Labels
2 Story Point Estimate community To tag external issues and PRs submitted by the community feature request To tag feature request after Hero Triage for PM to disposition

Comments

@jamesarosen
Copy link

jamesarosen commented Mar 16, 2022

Is your feature request related to a problem? Please describe.

Yes? The Ruby agent lacks features that the JS agent has, so we're missing data.

Feature Description

The Node JS agent supports sending all HTTP headers via the allow_all_headers flag. This results in attributes like request.headers.accept showing up as attributes on all Transactions. See New Relic Data Dictionary for more on those attributes.

Describe Alternatives

We can add each header as a custom attribute. This works fine, but it's a fair bit of extra code we have to maintain.

Priority

Really Want

T-Shirt size

@jamesarosen jamesarosen added the feature request To tag feature request after Hero Triage for PM to disposition label Mar 16, 2022
@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Mar 16, 2022
@tannalynn
Copy link
Contributor

Hello @jamesarosen
Thanks for letting us know about this feature you'd like to see in the ruby agent. I'll let our PM know so they can take a look.
Thank you!

@elucus
Copy link
Contributor

elucus commented Mar 24, 2022

Hi @jamesarosen thanks for the suggestion. We try and maintain feature parity with our agents and several agents have implemented support for capturing HTTP headers. We will add this to our backlog.

@angelatan2
Copy link
Contributor

Let's size this story and then assess next steps.

@angelatan2 angelatan2 removed the feature request To tag feature request after Hero Triage for PM to disposition label Sep 12, 2022
@workato-integration
Copy link

@angelatan2 angelatan2 added the feature request To tag feature request after Hero Triage for PM to disposition label Sep 12, 2022
@fallwith fallwith added this to the Feature smash! milestone Jun 5, 2023
@fallwith fallwith added the estimate Issue needing estimation label Jun 6, 2023
@kaylareopelle
Copy link
Contributor

Link to ticket where we worked on logging HTTP headers: #1839

@kford-newrelic kford-newrelic added 2 Story Point Estimate and removed estimate Issue needing estimation labels Jun 10, 2023
@fallwith fallwith self-assigned this Aug 1, 2023
fallwith added a commit that referenced this issue Aug 9, 2023
A new 'allow_all_headers' configuration parameter has been added to
bring parity with the Node.js agent and others. This configuration
parameter defaults to a value of `false`. When set to `true` and as
long as the agent is not operating in high security mode, all HTTP
headers gleaned from a request will be captured and relayed to New
Relic instead of the default core set of headers. All existing behavior
for `.*attributes.include` and `.*attributes.exclude` configuration
parameters will be respected for any desired filtration of the headers
when `allow_all_headers` is enabled. This work was done in response to
a feature request submitted by community member
[@jamesarosen](https://github.com/jamesarosen). Thank you very much,
@jamesarosen!

resolves #1029
@fallwith
Copy link
Contributor

Hi @jamesarosen, thanks again for suggesting this feature! The PR to introduce a new allow_all_headers config option is now in our dev branch and is slated to go out with in our next agent version.

@jamesarosen
Copy link
Author

Nice work, team 👏

@fallwith
Copy link
Contributor

Version 9.4.0 of the agent is now available from RubyGems.org.

CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story Point Estimate community To tag external issues and PRs submitted by the community feature request To tag feature request after Hero Triage for PM to disposition
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants