Subscribe to additional Action controller topics #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action controller tpoics
into separate file
notification subscriber tests
doing the exact same thing
tannalynn
commented
Jan 20, 2023
| @@ -163,42 +159,6 @@ def test_pop_segment_returns_false | |||
| end | |||
| end | |||
|
|
|||
| def test_start_logs_notification_error | |||
There was a problem hiding this comment.
Moved these tests into the notifications_subscriber.rb since these are testing what is now shared code
fallwith
suggested changes
Jan 20, 2023
lib/new_relic/agent/instrumentation/action_controller_other_subscriber.rb
Outdated
Show resolved
Hide resolved
lib/new_relic/agent/instrumentation/action_controller_other_subscriber.rb
Outdated
Show resolved
Hide resolved
|
|
||
| def finish_segment(name, id, payload) | ||
| raise NotImplementedError | ||
| end |
There was a problem hiding this comment.
This is a great cleanup, thank you.
lib/new_relic/agent/instrumentation/rails_notifications/action_controller.rb
Outdated
Show resolved
Hide resolved
…512_subscribe_actionview
Refactor ActionViewSubscriber methods `start` and `finish` (which now inherit from NotificationsSubscriber to `start_segment` and `finish_segment`.
fallwith
previously approved these changes
Jan 20, 2023
kaylareopelle
requested changes
Jan 20, 2023
lib/new_relic/agent/instrumentation/notifications_subscriber.rb
Outdated
Show resolved
Hide resolved
kaylareopelle
previously approved these changes
Jan 20, 2023
Subscribe to additional Action View topic
…b.com:newrelic/newrelic-ruby-agent into action_controller_subscriber_additional_topic
generic notification subscriber class
kaylareopelle
previously approved these changes
Jan 24, 2023
Use NewRelic::UNKNOWN const
fallwith
previously approved these changes
Jan 24, 2023
fallwith
previously approved these changes
Jan 24, 2023
SimpleCov Report
|
fallwith
approved these changes
Jan 24, 2023
| @@ -116,8 +114,6 @@ def test_super_operation_recorded_as_attribute_on_traces | |||
| trace = last_transaction_trace | |||
| tt_node = find_node_with_name(trace, "#{METRIC_PREFIX}#{DEFAULT_STORE}/read") | |||
|
|
|||
| puts txn.segments.last.inspect | |||
There was a problem hiding this comment.
Thank you for cleaning up these puts statements! Sorry I forgot to remove them!
kaylareopelle
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_processingbecause it was just creating duplicates of process_actionpassing on all versions with latest commit
closes #1510
closes #1512