-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nr1786 remove deprecated technologies #1788
Nr1786 remove deprecated technologies #1788
Conversation
Remove support for Rainbows - Ruby agent 9.0.0
Remove support for Sunspot - Ruby agent 9.0.0
Remove support for Datamapper - Ruby agent 9.0.0
Remove support for Authlogic - Ruby agent 9.0.0
Remove support for Acts As Solr - Ruby agent 9.0.0
SimpleCov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cleaning feels amazingggggg. thank youuuuuu
🧼 🛀 🧼 🛀
@@ -13,6 +13,14 @@ | |||
Support for Ruby 2.2 and 2.3 dropped with this release. They are no longer included in our test matrices and are not supported | |||
for 9.0.0 and onward. | |||
|
|||
- **Instrumentation dropped for select gems** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a general change log comment (since I'm so immersed in them atm) -- other agents, like Node, use **BREAKING**
before headings for breaking changes. This could be helpful here (though probs all of these entries are breaking)
Here's an example: https://docs.newrelic.com/docs/release-notes/agent-release-notes/nodejs-release-notes/node-agent-9-0-0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do you have plans to update the docs in a separate ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I like the "Breaking" headline for this. Perhaps in the final review of the 9.0.0 CHANGELOG, we can add some of this?
I forgot about the docs. I'll update the scope of this ticket and make a docs PR noting updated support (or lack of it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs PR created: newrelic/docs-website#11378
@@ -1239,13 +1239,6 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil) | |||
:deprecated => true, | |||
:description => 'Use [`disable_sequel_instrumentation`](#disable_sequel_instrumentation) instead.' | |||
}, | |||
:disable_data_mapper => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow! surprised this was our only setting!
@@ -101,7 +101,7 @@ def execute_suites(filter, opts) | |||
"agent" => %w[agent_only bare config_file_loading deferred_instrumentation high_security no_json json marshalling yajl], | |||
"background" => %w[delayed_job sidekiq resque], | |||
"background_2" => ["rake"], | |||
"database" => %w[datamapper elasticsearch mongo redis sequel], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also surprised this was our only test suite!
We deprecated support for a few gems in 8.7. No versions of the following gems will be supported as of 9.0.0, so their instrumentation and test files can be deleted:
Closes #1786
Docs PR to update support: newrelic/docs-website#11378