Major release 9 #1810
Major release 9 #1810
Conversation
concurrent ruby
enabled/disabled
its ready to be merged to dev
disabling tracing correctly
concurrent_invocation to work with thread tracing
to outside the if statement
Enable `instrumentation.thread.tracing` by default
It was deprecated, but the agent still uses it for the server side value but it can no longer be set by users through newrelic.ym or anything
updated tests accordingly
is not possible to work in env tests
Co-authored-by: James Bunch <fallwith@gmail.com>
Enable defer_rails_initialization config by environment variable only
| @@ -9,7 +9,7 @@ | |||
| DependencyDetection.defer do | |||
| # Why not just :grape? newrelic-grape used that name already, and while we're | |||
| # not shipping yet, overloading the name interferes with the plugin. | |||
| named :grape_instrumentation | |||
| @name = :grape_instrumentation | |||
There was a problem hiding this comment.
Why did we make this change to select instrumentation and not others?
There was a problem hiding this comment.
This was related to the configuration options we removed. Several of these are called something_instrumentation, but our configuration options are instrumentation.something. We have tests that expect configuration options called instrumentation.something_instrumentation when named is used, so we had to switch it to just set the name attribute directed.
…gent into major-release-9
SimpleCov Report
|
|
|
||
| instrumentation_methods :chain, :prepend | ||
|
|
||
| gemfile nil |
There was a problem hiding this comment.
What is this envfile doing?
There was a problem hiding this comment.
Not much lol. So we need to test the chain an prepend instrumentation, but since this is for the thread and fiber classes, there are no gems we need to install to test this, so we pass nil so it only creates a gemfile with the base multiverse gems we need.
There was a problem hiding this comment.
Cool, that makes sense :)
There was a problem hiding this comment.
This code (equivalent to gemfile(nil)) is invoking the gemfile method defined in multiverse/lib/multiverse/envfile.rb with nil as the argument.
It looks like doing so would accomplish the same as removing this gemfile nil line entirely. Perhaps it should be removed.
There was a problem hiding this comment.
Previously I was operating under the assumption that a gemfile call was needed to get a Gemfile.1 file created. But given this line in the gemfile method:
@gemfiles.push(content) unless content.nil? || content.empty?
that doesn't appear to be the case.
| threads = [] | ||
|
|
||
| threads << ::Thread.new do | ||
| # nothong |
Includes all changes for the 9.0 release
All PRs included in this branch