Fix for incorrectly private method in DecoratingFormatter #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
kaylareopelle
requested changes
Jun 14, 2023
SimpleCov Report
|
fallwith
approved these changes
Jun 14, 2023
kaylareopelle
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous refactor, the method
NewRelic::Agent::Logging::DecoratingFormatter#clear_tags!was included in the private section. This is a no op method that exists for rails compatibility, and should be public. This PR moves it back to public and adds a test to prevent this from happening in the futurecloses #2077