CI: Rework JRuby testing #2282
Merged
CI: Rework JRuby testing #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the latest stable JRuby for JRuby tests
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
For the `async_http` multiverse suite: - ignore JRuby, as it can not work with the required native extensions - ignore expected errors instead of having them hit STDOUT
for JRuby, allow multiple seen errors
for JRuby permit the odd extra event
relax assertions for JRuby, while still verifying the same object in the same way as CRuby
standardize on relaxing JRuby assertions for all collector calls
update `first_call_for` usage
Update the JRuby CI to run the latest version
fallwith
changed the title
fallwith
changed the title
Set JAVA_OPTS to explicitly permit JRuby to do the file related inflection it needs to do with the core Java libs
For some reason the hackish fake collector we use for testing has issues with JRuby but only when ran via GitHub Actions. For now at least, relax the 'exactly 1 call made for x' to be 'at least 1 call made for x' when JRuby is in play.
- Have JRuby test with Rails 7 - Use `::` prefix with the `Bloodhound` class
- constant namespacing - focus on unit tests
to address JRuby driven concurrent hash access issues, use dup instead of a mutex
JRuby CI: re-enable multiverse tests
the unit tests work with retry, so use it for multiverse as well
try running without retries
granular
combine individual suite running with retry
tweak GHA env vars
image, JAVA_OPTS
restore `--dev` for JRuby
restore 22 for multiverse
during manual testing, let's keep retries off
revert to an older JRuby
stick to the standalone basics
try the latest JRuby again
remove unit test services, misc cleanup
remove failed attempt to address a JRuby / Rails 7.0 test environment compatibility issue
remove the now unused script
SimpleCov Report
|
leverage the existing `suite_condition` pattern for skipping JRuby when testing a gem with native C extensions
kaylareopelle
previously approved these changes
Nov 27, 2023
tannalynn
previously approved these changes
Nov 27, 2023
fallwith
dismissed stale reviews from tannalynn and kaylareopelle
via
da4b4e4
kaylareopelle
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--debugunit_teststojruby_unit_teststo match thejruby_multiversenamescripts/retry_commandwith the use ofnick-fields/retryadd-opensJava opts and specifyXmxandXmsvaluesdupfor config hash resetting, as JRuby correctly points to it as having a potential race condition without thedupfirst_call_fortest helper that permits JRuby to have more than 1 call recorded while still examining the first callasync-httpsuite as it requires native C extensionsJRuby CI run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/6964342780