Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Security Agent comments to newrelic.yml #2773

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Add Security Agent comments to newrelic.yml #2773

merged 7 commits into from
Jul 25, 2024

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Jul 24, 2024 •
edited
Loading

Update newrelic.yml generator to include Security agent comments and regroup security configs at the bottom of the file.

Test coverage: 100%

closes #2753

@github-actions GitHub Actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.87% 93%
Branch 70.58% 50%

@hannahramadan hannahramadan marked this pull request as ready for review July 25, 2024 19:13
@hannahramadan hannahramadan merged commit 8e17c94 into dev Jul 25, 2024
32 checks passed
@hannahramadan hannahramadan deleted the add_security_comments_newrelicyml branch July 25, 2024 22:21
@hannahramadan hannahramadan mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fallwith fallwith Awaiting requested review from fallwith

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update newrelic.yml generator with new security configs
3 participants
@hannahramadan @kaylareopelle @fallwith