Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Rails v8.0 test fix, Rails v7.2 out of beta #2802

Merged
merged 2 commits into from
Aug 12, 2024
Merged

CI: Rails v8.0 test fix, Rails v7.2 out of beta #2802

merged 2 commits into from
Aug 12, 2024

Conversation

fallwith
Copy link
Contributor

@fallwith fallwith commented Aug 10, 2024

  • Rails v8.0 uses lazy routing, so expect the corresponding middleware metric to be present
  • Rails v7.2.0 is now released, so switch to using 7.2.0 instead of an alpha/beta/rc release

- Rails v8.0 uses lazy routing, so expect the corresponding middleware
  metric to be present
- Rails v7.2.0 is now released, so switch to using `7.2.0` instead of
  an alpha/rc release
For this Rails v7.2+ test, only check for send_test_stream as the
official non-beta release of v7.2.0 and Rails v8.0.0.alpha both only
result in send_test_stream being reported
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.88% 93%
Branch 70.69% 50%

@fallwith fallwith merged commit 4f71983 into dev Aug 12, 2024
32 checks passed
@fallwith fallwith deleted the sliar branch August 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants