Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use sqlite3 v2 for Rails EDGE #2818

Merged
merged 2 commits into from
Aug 19, 2024
Merged

CI: use sqlite3 v2 for Rails EDGE #2818

merged 2 commits into from
Aug 19, 2024

Conversation

fallwith
Copy link
Contributor

activerecord now needs sqlite3 v2+

activerecord now needs sqlite3 v2+
@fallwith
Copy link
Contributor Author

fallwith commented Aug 19, 2024

rails v8 alpha wants sqlite3 v2, but sqlite3 v2 insists on Rails <
3.4.0.dev
@@ -85,7 +85,7 @@ jobs:
"rails": "norails,rails61,rails70,rails71,rails72,railsedge"
},
"3.4.0-preview1": {
"rails": "norails,rails61,rails70,rails71,rails72,railsedge"
"rails": "norails,rails61,rails70,rails71,rails72"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context: #2819

Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.74% 93%
Branch 70.31% 50%

@fallwith fallwith merged commit 6bb8311 into dev Aug 19, 2024
140 checks passed
@fallwith fallwith deleted the marrowfat branch August 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants