Update check for installed_specs #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bundler::RubygemsIntegration.installed_specs method was added in version 2.5.12.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
kaylareopelle
changed the title
fallwith
previously approved these changes
Sep 18, 2024
hannahramadan
previously approved these changes
Sep 18, 2024
fallwith
previously approved these changes
Sep 18, 2024
tannalynn
reviewed
Sep 19, 2024
Co-authored-by: Tanna McClure <tmcclure@newrelic.com>
kaylareopelle
dismissed stale reviews from fallwith and hannahramadan
via
ccd055b
SimpleCov Report
|
hannahramadan
approved these changes
Sep 20, 2024
tannalynn
approved these changes
Sep 20, 2024
kaylareopelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bundler::RubygemsIntegration.installed_specsmethod was added in version 2.5.12. This PR updates the check to see ifBundler.rubygemsresponds toinstalled_specs.2.5.11: https://github.com/rubygems/rubygems/blame/bundler-v2.5.11/bundler/lib/bundler/rubygems_integration.rb#L471 (all_specs only)
2.5.12: https://github.com/rubygems/rubygems/blame/bundler-v2.5.12/bundler/lib/bundler/rubygems_integration.rb#L479 (both all_specs and installed_specs)