Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Ruby 3.4.0-preview2 #2894

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Test Ruby 3.4.0-preview2 #2894

merged 9 commits into from
Oct 10, 2024

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Oct 7, 2024

@kaylareopelle
Copy link
Contributor Author

Two test failures with the new version.


Unit tests:
NewRelic::Agent::Configuration::ManagerTest#test_logger_does_not_receive_excluded_settings [/opt/hostedtoolcache/Ruby/3.4.0-preview2/x64/lib/ruby/gems/3.4.0+0/gems/minitest-5.3.3/lib/minitest/assertions.rb:129]:
82
rails test /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/new_relic/agent/configuration/manager_test.rb:533
372


multiverse config_file_loading suite
ruby: prism/util/pm_newline_list.c:93: pm_newline_list_line_column: Assertion `cursor >= list->start' failed.
1349

Running "config_file_loading" using CHAIN for Envfile entry 1
1286
Starting tests in child PID 21523 at 2024-10-08 18:43:19 +0000
1287
Bundling in /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/suites/config_file_loading...
1288
WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
1289
stringio (>= 0)
1290
Available/installed versions of this gem:
1291
- 3.1.2.dev
1292
- 3.1.1

Theory: The switch to the prism parser is causing a problem for the fakefs gem used in this suite. The gem hasn't been updated since 2014. We may need to add an explicit stringio install in the Envfile.

@kaylareopelle
Copy link
Contributor Author

A test failure still exists on the CI that I'm not able to reproduce locally. It seems like a coincidence that the failure is also in config_file_loading. I'll try using a different bundler version tomorrow.

Running "config_file_loading" using CHAIN for Envfile entry 2
Starting tests in child PID 58391 at 2024-10-09 00:04:28 +0000
Bundling in /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/suites/config_file_loading...
WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
      stringio (>= 0)
      Available/installed versions of this gem:
      - 3.1.2.dev
      - 3.1.1
WARN: Clearing out unresolved specs. Try 'gem cleanup <gem>'
Please report a bug if this causes problems.
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies...
Using rake 13.2.1
Using bundler 2.4.1
Using base64 0.2.0
Using bigdecimal 3.1.8
Using fakefs 2.5.0
Using metaclass 0.0.4
Using minitest 5.16.3
Using minitest-stub-const 0.6
Using mutex_m 0.2.0
Using newrelic_rpm 9.14.0 from source at `/home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent` and installing its executables
Using ostruct 0.6.0
Using psych 3.3.4
Using warning 1.4.0
Using webrick 1.8.2
Using mocha 1.9.0
Bundle complete! 13 Gemfile dependencies, 15 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
ruby: prism/util/pm_newline_list.c:93: pm_newline_list_line_column: Assertion `cursor >= list->start' failed.
"config_file_loading" for Envfile entry 2 failed!

@kaylareopelle kaylareopelle self-assigned this Oct 9, 2024
@kaylareopelle
Copy link
Contributor Author

Explicitly installing stringio resolved the following warning:

WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
stringio (>= 0)
Available/installed versions of this gem:
- 3.1.2.dev
- 3.1.1
WARN: Clearing out unresolved specs. Try 'gem cleanup '

But, the suite still fails because of what looks like a prism error:

ruby: prism/util/pm_newline_list.c:93: pm_newline_list_line_column: Assertion `cursor >= list->start' failed.
"config_file_loading" for Envfile entry 2 failed!

I'd like to just skip the config_file_loading suite until a new preview version is released to see if there's a bug within Prism that, when fixed, will allow the suite to run.

@kaylareopelle kaylareopelle marked this pull request as ready for review October 9, 2024 21:59
fallwith
fallwith previously approved these changes Oct 9, 2024
fallwith
fallwith previously approved these changes Oct 9, 2024
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.78% 93%
Branch 69.62% 50%

@kaylareopelle kaylareopelle merged commit c96ac53 into dev Oct 10, 2024
32 checks passed
@kaylareopelle kaylareopelle deleted the ruby-3-4-0-preview-2 branch October 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants