DD: update the rendering of the 'named' line #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
lib/tasks/instrumentation_generator/templates/dependency_detection.tt
Outdated
Show resolved
Hide resolved
the template's rendering of a `named` line was previously attempting to wrap symbol values with single quotes when necessary. but given that everything is routed through the `snake_name` method, nothing will ever need the quotes if we simply use the output of that method, held in `@snake_name`.
fallwith
force-pushed
the
myxocyprinus
branch
from
f828947
to
2507052
Compare
kaylareopelle
approved these changes
Oct 22, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the template's rendering of a
namedline was previously attempting towrap symbol values with single quotes when necessary.
but given that everything is routed through the
snake_namemethod,nothing will ever need the quotes if we simply use the output of that
method, held in
@snake_name.