Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this PR fixes compatibility with jruby 9.3+
usually, programs don't need to access
JRuby.runtime
directly, so it's no longer available automatically since jruby 9.3for special cases like accessing object space, we need to load the runtime explicitly. This change is backward compatible.
Related Github Issue
#788 #784
Testing
the current CI on this project is more complex than I originally thought, many tested libraries are very outdated, rails 3 doesn't work well on jruby 9.3 anymore and I think there's one new bug in jruby's autoload... so CI switch should be done separately.
Reviewer Checklist