Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby 9.3 fixes #919

Merged
merged 1 commit into from
Jan 27, 2022
Merged

jruby 9.3 fixes #919

merged 1 commit into from
Jan 27, 2022

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Jan 25, 2022

Overview

this PR fixes compatibility with jruby 9.3+

usually, programs don't need to access JRuby.runtime directly, so it's no longer available automatically since jruby 9.3

for special cases like accessing object space, we need to load the runtime explicitly. This change is backward compatible.

Related Github Issue

#788 #784

Testing

the current CI on this project is more complex than I originally thought, many tested libraries are very outdated, rails 3 doesn't work well on jruby 9.3 anymore and I think there's one new bug in jruby's autoload... so CI switch should be done separately.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022

CLA assistant check
All committers have signed the CLA.

@kaylareopelle
Copy link
Contributor

Thank you for submitting the fix in this PR and the others for JRuby support! Our team will review the PRs today and get back to you with any suggestions.

@kaylareopelle kaylareopelle self-requested a review January 27, 2022 16:07
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining the reasoning behind this change in the description of the PR!

@kaylareopelle kaylareopelle merged commit 0dbabec into newrelic:dev Jan 27, 2022
@kaylareopelle kaylareopelle linked an issue Jan 27, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support JRuby 9.3.0.0
3 participants