Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added node-gyp to be used by prebuildify instead of relying on the default version from npm #244

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

Links

Closes #243

Details

Prebuildify will use stock node-gyp if one is not present. Node 16 ships with v9 of node-gyp which does not work with python 3.12.2.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (d7c339a) to head (2e3e201).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files           1        1           
  Lines         183      183           
=======================================
  Hits          179      179           
  Misses          4        4           
Flag Coverage Δ
integration-tests-16-macos-14-arm64 ?
integration-tests-16-ubuntu-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x86 85.24% <ø> (ø)
integration-tests-18-macos-14-arm64 ?
integration-tests-18-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x86 84.15% <ø> (ø)
integration-tests-20-macos-14-arm64 ?
integration-tests-20-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x86 84.15% <ø> (ø)
unit-tests-16-macos-14-arm64 93.44% <ø> (ø)
unit-tests-16-ubuntu-latest-x64 ?
unit-tests-16-windows-latest-x64 93.44% <ø> (ø)
unit-tests-16-windows-latest-x86 93.44% <ø> (ø)
unit-tests-18-macos-14-arm64 92.34% <ø> (ø)
unit-tests-18-ubuntu-latest-x64 ?
unit-tests-18-windows-latest-x64 92.34% <ø> (ø)
unit-tests-18-windows-latest-x86 92.34% <ø> (ø)
unit-tests-20-macos-14-arm64 92.34% <ø> (ø)
unit-tests-20-ubuntu-latest-x64 ?
unit-tests-20-windows-latest-x64 92.34% <ø> (ø)
unit-tests-20-windows-latest-x86 92.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for macos 14 node 16
2 participants