You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At some point in the past, it was decided these should be in their own repository. Presumably, the thinking was that clients who need fixes in the specific instrumentations they provide could update those modules without having to wait for a new release of newrelic. That may be true, but the reality is that it isn't worth the complications it brings. Namely:
There are circular dependencies between the external packages and newrelic. As an example the difficulty this causes see fix: Fixed instrumenting the same module installed in different locations #2104. It was difficult to orchestrate because changes needed to be made in at least the aws-sdk package the required coordinating with a new release of newrelic merely to move development of the PR along.
Description
There are a set of repos that provide instrumentation features within the
newrelic
agent. They are:At some point in the past, it was decided these should be in their own repository. Presumably, the thinking was that clients who need fixes in the specific instrumentations they provide could update those modules without having to wait for a new release of
newrelic
. That may be true, but the reality is that it isn't worth the complications it brings. Namely:newrelic
. As an example the difficulty this causes see fix: Fixed instrumenting the same module installed in different locations #2104. It was difficult to orchestrate because changes needed to be made in at least theaws-sdk
package the required coordinating with a new release ofnewrelic
merely to move development of the PR along.newrelic
without impacting the releases of the external modules. As an example, chore: Attached specs to theShim.prototype
for use in custom instrumentation and instrumentation outside of the agent #2038 resulted in a new version of bothnewrelic
andaws-sdk
. Folks updatedaws-sdk
without updatingnewrelic
and found themselves in a broken state becauseaws-sdk
couldn't find the code it needed.To fix these issues, and make our development of
newrelic
easier and more robust, we need to migrate these modules into the mainnewrelic
code base.Ideally, we will keep the histories of those external repos by utilizing
--allow-unrelated-histories
.Note: https://github.com/newrelic/node-newrelic/blob/c32cb2739ece3adcf5bd42e646071b3f59e691ba/test/versioned-external/external-repos.js should be updated as repos are migrated.
The text was updated successfully, but these errors were encountered: