Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @newrelic/aws-sdk into repo #2125

Closed
jsumners-nr opened this issue Apr 4, 2024 · 2 comments · Fixed by #2161
Closed

Migrate @newrelic/aws-sdk into repo #2125

jsumners-nr opened this issue Apr 4, 2024 · 2 comments · Fixed by #2161
Assignees
@bizob2828
Labels
points: 8

Comments

@jsumners-nr
Copy link
Contributor

jsumners-nr commented Apr 4, 2024 •
edited by bizob2828
Loading

See #2123

Tasks:

  • deprecate the @newrelic/aws-sdk package
  • Update lib/instrumentations.js to register a relative folder
  • Remove the external versioned tests configuration.
  • update tests to use test/lib/agent_helper instead of @newrelic/test-utilities
  • Migrate the smoke tests and github secrets accordingly
  • Migrate the aws server stub from test utils to the agent
  • Move llm events to the agent lib/llm folder
  • Convert git history with the previous repo.
  • Archive old repo when done.
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-256218

@bizob2828
Copy link
Member

As part of this I think we should move some code around. specifically the llm events

@kmudduluru kmudduluru added points: 5 1-2 weeks and removed needs-triage labels Apr 9, 2024
@bizob2828 bizob2828 added points: 8 and removed points: 5 1-2 weeks labels Apr 9, 2024
@bizob2828 bizob2828 self-assigned this Apr 17, 2024
@bizob2828 bizob2828 mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
points: 8
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Migrated @newrelic/aws-sdk into agent repo bizob2828/node-newrelic
3 participants
@bizob2828 @jsumners-nr @kmudduluru