Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move middleware, db operation and parsed-statement metric functions to lib/metrics/recorders #2656

Closed
bizob2828 opened this issue Oct 14, 2024 · 1 comment · Fixed by #2666
Closed

Move middleware, db operation and parsed-statement metric functions to lib/metrics/recorders #2656

bizob2828 opened this issue Oct 14, 2024 · 1 comment · Fixed by #2666
Assignees
@svetlanabrennan
Labels
points: 3 A few days

Comments

@bizob2828
Copy link
Member

Description

There are 3 metrics recorders that do no live in lib/metrics/recorders: _recordOperationMetrics(lib/shim/datastore-shim.jsand middlewareMetricRecorder(lib/shim/webframework-shim/middleware.js, and parts of recordMetrics(lib/db/parsed-statement.js)
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-326047

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Oct 14, 2024
@kmudduluru kmudduluru added points: 3 A few days and removed needs-triage labels Oct 15, 2024
@svetlanabrennan svetlanabrennan self-assigned this Oct 16, 2024
@svetlanabrennan svetlanabrennan mentioned this issue Oct 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svetlanabrennan svetlanabrennan

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Status: Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: moved recorders to lib/metrics/recorders svetlanabrennan/node-newrelic
3 participants
@bizob2828 @svetlanabrennan @kmudduluru