chore: moved recorders to lib/metrics/recorders
#2666
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 97.21% 97.18% -0.03%
==========================================
Files 291 294 +3
Lines 45928 45968 +40
==========================================
+ Hits 44650 44676 +26
- Misses 1278 1292 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svetlanabrennan
changed the title
lib/metrics/recorders
| * @param {string} metricName name of metric | ||
| * @returns {Function} recorder for middleware | ||
| */ | ||
| function makeMiddlewareRecorder(_shim, metricName) { |
There was a problem hiding this comment.
there's redundancy in the file. i would just name this middleware.js
There was a problem hiding this comment.
I file name or the function name as well?
| * @see DatastoreShim#recordOperation | ||
| * @see MetricFunction | ||
| */ | ||
| function recordOperationMetrics(segment, scope) { |
There was a problem hiding this comment.
i need to study this but seems like this is very similar to the metrics recorder from parsed statement.
|
|
||
| 'use strict' | ||
|
|
||
| const metrics = require('../../metrics/names') |
There was a problem hiding this comment.
i would rename this to database-operation.js
Description
Moved 3 metric recorder functions to
lib/metrics/recorders.How to Test
Run unit tests
Related Issues
Fixes #2656