chore: moved recorders to lib/metrics/recorders
#2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 97.21% 97.17% -0.04%
==========================================
Files 291 294 +3
Lines 45928 46096 +168
==========================================
+ Hits 44650 44796 +146
- Misses 1278 1300 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svetlanabrennan
changed the title
lib/metrics/recorders
bizob2828
requested changes
Oct 17, 2024
bizob2828
requested changes
Oct 23, 2024
|
@bizob2828 I addressed your comments and pushed up my changes. |
bizob2828
requested changes
Oct 30, 2024
Co-authored-by: Bob Evans <robert.evans25@gmail.com>
Merged
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Bob Evans <robert.evans25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved 3 metric recorder functions to
lib/metrics/recorders.How to Test
Run unit tests
Related Issues
Fixes #2656