Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Jade template to HTML #280

Closed
szaranger opened this issue Jun 12, 2019 · 5 comments
Closed

Convert Jade template to HTML #280

szaranger opened this issue Jun 12, 2019 · 5 comments

Comments

@szaranger
Copy link

Not everybody uses Jade. Please convert this to HTML

@astormnewrelic
Copy link
Contributor

Nice to meet you you szaranger, and thanks for your feedback/attention!

That said -- we're not 100% sure what use of jade you're referring to. The New Relic agent itself doesn't use jade for any functionality.

If you're referring to our docs (this? somewhere else?) -- the intent of that passage isn't to advocate or recommend jade -- jade just happens to be the library we chose to show the general concept. Per those same docs.

Although the specifics are different for other frameworks, the general approach described below should work in most cases.

In our experience a majority of our users are usually using some sort of templating engine, and it's important for our docs to reflect that.

Do you have a suggestion for a better templating engine we could use as an example? Or have you spotted other uses of jade in our docs? Or have I completely misunderstood what your issue posting was about? :)

@szaranger
Copy link
Author

I'm using NextJS and never used Jade/Pug so had to learn Jade to convert your example to HTML. So if the documentation had it in HTML, it will be useful for the users

@astormnewrelic
Copy link
Contributor

@szaranger I see, thanks for sharing. Do you have any suggestions for how we could write the docs in such a way that we cover, conceptually, both the HTML use case and the template engine use case?

@astormnewrelic
Copy link
Contributor

@szaranger We're still open to hearing about solutions that cover the use cases we described. If you're interested in coming back to this either open a PR, or reopen the issue to revive the discussion. Thanks! :)

@szaranger
Copy link
Author

@astormnewrelic I guess it’s good to have both HTML and Jade examples. Handlebars templates for example use HTML

bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 19, 2024
Co-authored-by: jsumners-nr <gh-actions-jsumners-nr@github.com>
Co-authored-by: James Sumners <jsumners@newrelic.com>
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 23, 2024
Co-authored-by: jsumners-nr <gh-actions-jsumners-nr@github.com>
Co-authored-by: James Sumners <jsumners@newrelic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants