ci: Add Node.js 20.x to CI and remove 14.x #1603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Closes #1726
Details
This was mostly a clean upgrade. I have skipped the ESM tests as we know the ESM loader isn't working. I will unleash those tests when I PR that fix. The highlights here are that server.close changed behavior so I just made tests bind to dynamic ports to workaround this issue. There's also 2 features that no longer ship with node around dtrace and etw.