tracer: update to newest version of CLS #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@othiym23 So I'm going through this and am finding that |
|
Nevermind, I'm super dumb. The new CLS got pulled down, so I thought we had this merged for some reason. Your patch makes the tests pass. Thanks! |
|
You're welcome! 🙇 |
cmcadams-newrelic
pushed a commit
to cmcadams-newrelic/node-newrelic
that referenced
this pull request
Jan 29, 2024
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 16, 2024
…/follow-redirects-1.15.4 Bump follow-redirects from 1.15.3 to 1.15.4
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
….290.0-breaking-change Skipping aws-sdk version 3.290.0
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
….290.0-breaking-change Skipping aws-sdk version 3.290.0
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Jul 26, 2024
…/follow-redirects-1.15.4 chore(deps-dev): bump follow-redirects from 1.15.3 to 1.15.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect, I probably should have bumped CLS to 4.0.0, but the bits that changed in
node-newrelicwere using undocumented internals that I originally piggybacked upon to avoid needing 2 async listeners to handle CLS and error tracing. As a workaround, I updated the dependency inpackage.jsonso that you won't somehow end up with a version of CLS with the old internal API.continuation-local-storage@3.1.0includes @groundwater's fix for othiym23/async-listener#19 / othiym23/async-listener#20, which is the main motivator for the upgrade. All tests are passing (although you should probably upgradeCONTRIBUTING.mdto reflect the fact thatboot2dockeris also a dependency for running the integration tests).