support groups in createBackgroundTransaction stub #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Howdy @nullvariable, sorry this got missed. The week you put this up was a very busy week for the team. I've added testing this to my todo list for this week. If you don't mind squashing your commits into a single one that'd be wonderful. Thanks! |
in api.js:433 the createBackgroundTransaction function supports up to three arguments with the second argument being optional. If the api fails to load and the stub fallback is used, it will fail in cases where three arguments were used. I've updated the createBackgroundTransaction stub to support all three arguments conditionally. tests to support group argument for createBackgroundTransaction
|
@wraithan no worries, I think that squashed it into one commit, let me know if that didn't work. |
|
@nullvariable So we should be merging this in this week. I was wondering how you prefer to be attributed in the release notes. We are happy to use your name as it appears on github, your github handle, or any other identifier you prefer. |
|
github handle works great, thanks! |
|
@nullvariable Your patch was merged out of band (and rebased). Thanks for the PR! |
cmcadams-newrelic
pushed a commit
to cmcadams-newrelic/node-newrelic
that referenced
this pull request
Jan 29, 2024
…/error-fingerprinting/fast-xml-parser-and-artillery-4.1.2 chore(deps): bump fast-xml-parser and artillery in /error-fingerprinting
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 16, 2024
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Jul 26, 2024
feat: Added a shim to externalize all 3rd party libraries the Node.js agent instruments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full api for createBackgroundTransaction supports three arguments with the second argument being optional. The fallback stub only supported the name and callback arguments. I've update the stub and the tests to support the optional group argument as the full version of the api does.
Thanks!