Fix issue with chainable on calls in pg. #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianhoitz Good catch! Thanks for sending us the PR. We should be able to get this into our release this week. |
|
@sebastianhoitz So we should be merging this in this week. I was wondering how you prefer to be attributed in the release notes. We are happy to use your name as it appears on github, your github handle, or any other identifier you prefer. |
|
@sebastianhoitz Your patch was merged out of band (and rebased). Closing this PR. Thanks a ton for the patch! |
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 16, 2024
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Jul 26, 2024
Release v0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventEmitters
onmethod is chainable as documented here: http://nodejs.org/api/events.html#events_emitter_on_event_listenerBy not returning the handler you introduce a breaking behavior that other libraries (like SequelizeJS) might rely on.