feat: Added instrumentation for fetch. #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
fetch
branch
5 times, most recently
from
bb86154
to
57ffd9a
Compare
undici. Updated test harness to use this.
Codecov Report
@@ Coverage Diff @@
## main #1776 +/- ##
=======================================
Coverage 96.83% 96.84%
=======================================
Files 198 198
Lines 38734 38755 +21
=======================================
+ Hits 37510 37531 +21
Misses 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mrickard
approved these changes
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the registering of undici instrumentation to the core functions. Since this just subscribes to events on the diagnostic channel it doesn't need to get keyed off of when undici is required. You can see in the refactor I changed from doing
dc.channel('name').subscribe(<hoook>)in the export to creating channel and saving reference. Then subscribing separately. This suggestion is detailed out here which was fixed in Node.js core here.Note: I tried updating to do
diagnosticsChannel.subscribe(<name>, <hook>)which worked great but caused slowness in tearing down some versioned test suites only in Node 20. Long term this is the ideal approach to subscribing but we'll need to triage this at a later dateLinks
Closes #1773