fix: Update import-in-the-middle to fix ESM on Node 18.19.0 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
fix-v18.19
branch
from
9cb9f4e
to
e42de4d
Compare
jsumners-nr
force-pushed
the
fix-v18.19
branch
from
e42de4d
to
52bd626
Compare
bizob2828
approved these changes
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 209 209
Lines 39872 39872
=======================================
Hits 38631 38631
Misses 1241 1241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js v18.19.0 includes a backport of ESM loaders happening on a separate thread (nodejs/node@bac9b17). This caused
import-in-the-middleto not load ESM correctly. The latest version includes a fix to properly load ESM on v18.19.0. So this PR updates our minimum supported version accordingly.