Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed CI jobs #2215

Merged
merged 1 commit into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions .github/workflows/ci-workflow.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Node Agent CI

on: [push, pull_request, workflow_dispatch]
on:
push:
pull_request:
workflow_dispatch:

env:
# Enable versioned runner quiet mode to make CI output easier to read:
Expand Down Expand Up @@ -40,8 +43,9 @@ jobs:
lint:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ubuntu-latest

strategy:
Expand All @@ -62,8 +66,9 @@ jobs:
ci:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ubuntu-latest

strategy:
Expand All @@ -85,8 +90,9 @@ jobs:
unit:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ubuntu-latest

strategy:
Expand All @@ -113,8 +119,9 @@ jobs:
integration:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ubuntu-latest

env:
Expand Down Expand Up @@ -153,8 +160,9 @@ jobs:
versioned-internal:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ${{ github.ref == 'refs/heads/main' && vars.NR_RUNNER || 'ubuntu-latest' }}

strategy:
Expand Down Expand Up @@ -203,8 +211,9 @@ jobs:
versioned-external:
needs:
- should_run
if: needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true'
if: github.event_name == 'workflow_dispatch' ||
(needs.should_run.outputs.javascript_changed == 'true' ||
needs.should_run.outputs.deps_changed == 'true')
runs-on: ${{ github.ref == 'refs/heads/main' && vars.NR_RUNNER || 'ubuntu-latest' }}

strategy:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/compatibility-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,17 @@ jobs:
arch: amd64
cache: enable
- run: |
nrversions -v -r agent -R ${DOCS_TARGET} 2>docs-status.log
nrversions -v -r agent -R ./docs/${DOCS_TARGET} 2>docs-status.log

# Upload generated artifacts for potential debugging purposes.
- uses: actions/upload-artifact@v4
with:
name: docs-status.log
path: docs-status.log
- uses: actions/upload-artifact@v4
with:
name: compatibility-requirements-nodejs-agent.mdx
path: docs/${{ env.DOCS_TARGET }}

# Generate the new PR to update the doc in the repo.
- run: |
Expand All @@ -109,4 +113,5 @@ jobs:
branch: "nodejs-compatibility-report/auto-update"
delete-branch: true
base: develop
path: docs
labels: "documentation"
Loading