Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added kafkajs instrumentation and versioned tests skeleton #2224

Merged
merged 10 commits into from
May 30, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented May 29, 2024

This PR resolves #2222.

@jsumners-nr jsumners-nr marked this pull request as ready for review May 29, 2024 16:57
@jsumners-nr jsumners-nr requested a review from bizob2828 May 29, 2024 16:57
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor tweaks

test/versioned/node-rdkafka/kafka.tap.js Outdated Show resolved Hide resolved
test/versioned/node-rdkafka/kafka.tap.js Outdated Show resolved Hide resolved
test/versioned/node-rdkafka/package.json Outdated Show resolved Hide resolved
@bizob2828 bizob2828 changed the title chore: Added node-rdkafka versioned tests skeleton chore: Added kafkajs versioned tests skeleton May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[kafkajs] Instrumentation baseline skeleton
2 participants