Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Updated security agent workflow to use large runners when available #2271

Merged
merged 4 commits into from
Jun 12, 2024
Merged

ci: Updated security agent workflow to use large runners when available #2271

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d56b0c
ci: Updated security agent workflow to use large runners when available
bizob2828 Jun 12, 2024
decbc15
chore: fixed syntax
bizob2828 Jun 12, 2024
1be4883
Merge branch 'main' into use-large-runner
bizob2828 Jun 12, 2024
eab5dc3
chore: update jobs if using NR_RUNNER
bizob2828 Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/versioned-security-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
github.event_name == 'schedule' ||
needs.should_run.outputs.sec_agent_did_change == 'true'

runs-on: {{ vars.NR_RUNNER || 'ubuntu-latest' }}
runs-on: ${{ vars.NR_RUNNER || 'ubuntu-latest' }}

strategy:
fail-fast: false
Expand All @@ -82,6 +82,7 @@ jobs:
run: TEST_CHILD_TIMEOUT=600000 npm run versioned:security
env:
VERSIONED_MODE: --${{ inputs.mode || 'major' }}
JOBS: 4 # 2 per CPU seems to be the sweet spot in GHA (July 2022)
# Run more jobs when using larger runner, otherwise 2 per CPU seems to be the sweet spot in GHA default runners(July 2022)
JOBS: ${{ vars.NR_RUNNER && 16 || 4 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised the GHA parser is this robust.

SKIP_C8: true

Loading