Keep correct transaction when calling Bluebird promise.nodeify nodeback #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the build failures were introduced by my change, but let me know if there is something I need to change. |
|
@mdlavin Thanks for the pr! No need to worry about the tests, the failures are due to environmental differences and we are going to fix those up shortly. The changes look good, we'll include this in the next release! |
|
this pr was merged out of band in v1.35.0, thanks again for the pr, @mdlavin ! |
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
Co-authored-by: Bob Evans <robert.evans25@gmail.com>
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
Co-authored-by: Bob Evans <robert.evans25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Bluebird's
promise.nodeifythe current transaction is lost. The same support forasCallbackshould also be provied tonodeifysince they are aliases of each other.