Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ARN and provider to Lambda segments #2674

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

mrickard
Copy link
Member

@mrickard mrickard commented Oct 23, 2024

Description

Entity linking for Lambda functions requires standardized attributes being added to transaction trace segments: cloud.resource_id and cloud.provider. This PR adds them.

How to Test

@svetlanabrennan added assertions to the aws-lambda unit test; running serverless unit tests shows that these are present.

Related Issues

Closes #2586
Closes NR-314346

…for Lambda traces

Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (b25cff0) to head (7806842).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
+ Coverage   88.83%   97.18%   +8.35%     
==========================================
  Files         290      291       +1     
  Lines       45914    45931      +17     
==========================================
+ Hits        40787    44639    +3852     
+ Misses       5127     1292    -3835     
Flag Coverage Δ
integration-tests-cjs-18.x 74.17% <0.00%> (?)
integration-tests-cjs-20.x 74.16% <0.00%> (-0.02%) ⬇️
integration-tests-cjs-22.x 74.21% <0.00%> (-0.01%) ⬇️
integration-tests-esm-18.x 49.70% <0.00%> (-0.01%) ⬇️
integration-tests-esm-20.x 49.71% <0.00%> (-0.01%) ⬇️
integration-tests-esm-22.x 49.73% <0.00%> (-0.01%) ⬇️
unit-tests-18.x 88.87% <100.00%> (?)
unit-tests-20.x 88.87% <100.00%> (?)
unit-tests-22.x 88.87% <100.00%> (?)
versioned-tests-18.x 78.92% <0.00%> (-0.19%) ⬇️
versioned-tests-20.x 78.95% <0.00%> (-0.17%) ⬇️
versioned-tests-22.x 78.93% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard merged commit a23294c into newrelic:main Oct 29, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

feat: Add ARN-tracking attributes to AWS Lambda segments and spans
2 participants