Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added labels.enabled and labels.exclude to config defaults #2727

Merged

Conversation

svetlanabrennan
Copy link
Contributor

Description

Updated default configs to accept application_logging.forwarding.labels.enabled and application_logging.forwarding.labels.exclude to support adding labels to log records.

Docs website will be updated with these configs in #2716

How to Test

Added and updated unit tests

Related Issues

Closes #2713
Relates to #2716

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (a901a24) to head (1017cff).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a901a24) and HEAD (1017cff). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (a901a24) HEAD (1017cff)
unit-tests-18.x 1 0
unit-tests-20.x 1 0
integration-tests-cjs-18.x 1 0
integration-tests-cjs-22.x 1 0
integration-tests-cjs-20.x 1 0
integration-tests-esm-18.x 1 0
integration-tests-esm-22.x 1 0
integration-tests-esm-20.x 1 0
versioned-tests-18.x 1 0
versioned-tests-22.x 1 0
versioned-tests-20.x 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   97.25%   88.94%   -8.32%     
==========================================
  Files         294      276      -18     
  Lines       46198    44743    -1455     
==========================================
- Hits        44930    39795    -5135     
- Misses       1268     4948    +3680     
Flag Coverage Δ
integration-tests-cjs-18.x ?
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x ?
integration-tests-esm-18.x ?
integration-tests-esm-20.x ?
integration-tests-esm-22.x ?
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x 88.94% <100.00%> (+<0.01%) ⬆️
versioned-tests-18.x ?
versioned-tests-20.x ?
versioned-tests-22.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/unit/config/config-env.test.js Outdated Show resolved Hide resolved
test/unit/config/config-env.test.js Outdated Show resolved Hide resolved
lib/config/default.js Show resolved Hide resolved
lib/config/default.js Outdated Show resolved Hide resolved
@svetlanabrennan svetlanabrennan merged commit 36adb13 into newrelic:main Nov 13, 2024
23 of 27 checks passed
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Add application logging labels config to defaults
3 participants