feat: Adds new configuration options to add custom tags (labels) to logs #2743
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
- Coverage 97.25% 97.21% -0.05%
==========================================
Files 294 294
Lines 46233 46310 +77
==========================================
+ Hits 44965 45020 +55
- Misses 1268 1290 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…on config as `parsedLabels` and `loggingLabels`, moved tests around
There was a problem hiding this comment.
approving but since I made updates on @svetlanabrennan's behalf, I'll wait for @jsumners-nr to approve as well
lib/config/index.js
Outdated
| * Compares the labels list to the excluded label list and removes any labels that need to be excluded. | ||
| * Then prefixing each label with "tags." | ||
| */ | ||
| Config.prototype._filterLabels = function filterLabels() { |
There was a problem hiding this comment.
i'd add some tests in config unit tests that assert the labels are getting set accordingly. I know they are being tested in the log aggregator but it'll be hard to identified where this is getting covered in the future
lib/aggregators/log-aggregator.js
Outdated
| @@ -24,6 +28,7 @@ class LogAggregator extends EventAggregator { | |||
|
|
|||
| super(opts, agent) | |||
| this.agent = agent | |||
| createFeatureUsageMetrics(agent) | |||
There was a problem hiding this comment.
we were missing some supportability metrics per spec. This story was supposed to add the Supportability/Logging/Labels/Nodejs/<enabled|disabled>
Description
How to Test
Run unit tests.
Related Issues
Closes #2716
TODO