Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provided ability to disable instrumentation for core Node.js libraries #2927

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

bizob2828
Copy link
Member

Description

Followed the pattern I did in #2551. I manually added undici and domain as they don't follow the same pattern as the other core instrumentation.

Related Issues

Closed #2926

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 92.02899% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.36%. Comparing base (8606f78) to head (6bce486).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/shimmer.js 85.71% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   97.43%   97.36%   -0.07%     
==========================================
  Files         314      315       +1     
  Lines       48074    48125      +51     
==========================================
+ Hits        46839    46855      +16     
- Misses       1235     1270      +35     
Flag Coverage Δ
integration-tests-cjs-18.x ?
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x 72.56% <92.02%> (+0.02%) ⬆️
integration-tests-esm-18.x 49.67% <92.02%> (+0.04%) ⬆️
integration-tests-esm-20.x 49.67% <92.02%> (+0.04%) ⬆️
integration-tests-esm-22.x 49.73% <92.02%> (+0.04%) ⬆️
unit-tests-18.x 89.15% <92.02%> (-0.01%) ⬇️
unit-tests-20.x 89.15% <92.02%> (-0.01%) ⬇️
unit-tests-22.x 89.16% <92.02%> (-0.01%) ⬇️
versioned-tests-18.x 79.21% <92.02%> (-0.18%) ⬇️
versioned-tests-20.x 79.22% <92.02%> (-0.18%) ⬇️
versioned-tests-22.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 2d232f1 into newrelic:main Feb 10, 2025
27 of 29 checks passed
@bizob2828 bizob2828 deleted the disable-core-instrumentation branch February 10, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Provide ability to disable core node.js instrumentation
2 participants