feat: Propagate agent root context when opentelemetry ROOT_CONTEXT is passed in to trace propagator. Added logic to handle properly naming and ending transactions for server spans.
#2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Feb 11, 2025
jsumners-nr
previously approved these changes
Feb 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
==========================================
+ Coverage 88.88% 97.30% +8.41%
==========================================
Files 315 317 +2
Lines 48395 48619 +224
==========================================
+ Hits 43018 47309 +4291
+ Misses 5377 1310 -4067
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
passed in to trace propagator. Added logic to handle properly naming and ending transactions for server spans.
bizob2828
force-pushed
the
otel-propagator
branch
from
ae51c8b to
006e431
Compare
jsumners-nr
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts the groundwork to properly propagate trace context. For now it's just being used to propagate our root context instead of otel's root context. I also added logic to properly name server span transactions and reconcile the relevant segment attributes with tests. There is missing test coverage in the trace propagator which will be handled in #2662
Related Issues
Closes #2936