Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for region-prefixed Bedrock models #2947

Conversation

bizob2828
Copy link
Member

Description

#2937 wasn't targetting main. This PR does that.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (8606f78) to head (2c11aea).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
- Coverage   97.43%   97.40%   -0.03%     
==========================================
  Files         314      317       +3     
  Lines       48074    48638     +564     
==========================================
+ Hits        46839    47376     +537     
- Misses       1235     1262      +27     
Flag Coverage Δ
integration-tests-cjs-18.x 72.83% <0.00%> (+0.51%) ⬆️
integration-tests-cjs-20.x 72.83% <0.00%> (+0.50%) ⬆️
integration-tests-cjs-22.x 73.05% <0.00%> (+0.51%) ⬆️
integration-tests-esm-18.x 50.48% <0.00%> (+0.85%) ⬆️
integration-tests-esm-20.x 50.49% <0.00%> (+0.85%) ⬆️
integration-tests-esm-22.x 50.54% <0.00%> (+0.85%) ⬆️
unit-tests-18.x 89.25% <100.00%> (+0.08%) ⬆️
unit-tests-20.x 89.25% <100.00%> (+0.08%) ⬆️
unit-tests-22.x 89.25% <100.00%> (+0.08%) ⬆️
versioned-tests-18.x 79.94% <100.00%> (+0.54%) ⬆️
versioned-tests-20.x 79.94% <100.00%> (+0.54%) ⬆️
versioned-tests-22.x 79.95% <100.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 6acf535 into main Feb 12, 2025
53 of 54 checks passed
@bizob2828 bizob2828 deleted the NR-361592-OE-Node-agent-does-not-match-cross-region-inference-model-names-in-Bedrock branch February 12, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

3 participants