fix: Updated api.recordLogEvent to no longer truncate the message key in log event
#2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
bizob2828
requested changes
Feb 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
- Coverage 97.35% 97.30% -0.05%
==========================================
Files 317 317
Lines 48625 48690 +65
==========================================
+ Hits 47337 47379 +42
- Misses 1288 1311 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rChaoz
force-pushed
the
fix/log-truncate
branch
from
c63362e to
be1332a
Compare
bizob2828
previously approved these changes
Feb 13, 2025
bizob2828
reviewed
Feb 13, 2025
bizob2828
approved these changes
Feb 13, 2025
bizob2828
changed the title
api.recordLogEvent to no longer truncate the message key in log event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the related issue: fixes #2921
In short:
logEvent.messagecan either be a simple string message, in which truncating is OK, but it can also be the full JSON log (stringified), in which case it mustn't be truncated.