feat: Added ability to propagate traceparent and tracestate on incoming server/consumer spans and outgoing client http and producer spans

[bizob2828]

Description

This PR finalizes the propagation of traceparent/tracestate headers. For incoming server spans it's a 2 step process, instrumentation will call propagation.extract to get the new context based on traceparent/tracestate. Then when a server span's transaction is started it will accept the payload and assign the necessary attributes on the transaction. For this to be supported I had to enhance Transaction to pass in the traceId if present. This is so the trace id created from otel instrumentation will also be the transaction trace id. Previously, this was a lazy property and created a unique id the first time it was accessed.

For outging client spans, it calls propagation.inject which will get the relevant traceId, spanId, sampled flag on the active span and inject into the outgoing headers. I also had to enhance TraceSegment to pass in id(spanId) if present.

How to Test

unit and versioned tests assert the new logic. I also manually tested with our new examples and have confirmed DT linking it done accordingly.

Related Issues

Closes #2662

[bizob2828]

i can remove this but realized this was redundant as transaction.end does this as well

[bizob2828]

this was done in prep for the removal of the register method, see

[codecov]

Codecov Report

Attention: Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (8943672) to head (9300939).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/otel/trace-propagator.js	58.33%	5 Missing ⚠️
lib/transaction/tracecontext.js	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
- Coverage   79.87%   79.85%   -0.03%     
==========================================
  Files         307      308       +1     
  Lines       47588    47650      +62     
==========================================
+ Hits        38012    38050      +38     
- Misses       9576     9600      +24     

Flag	Coverage Δ
integration-tests-esm-18.x	49.95% <44.85%> (+0.02%)	⬆️
integration-tests-esm-20.x	49.96% <44.85%> (+0.02%)	⬆️
integration-tests-esm-22.x	50.01% <44.85%> (+0.02%)	⬆️
versioned-tests-18.x	79.76% <93.45%> (-0.03%)	⬇️
versioned-tests-20.x	79.74% <93.45%> (-0.05%)	⬇️
versioned-tests-22.x	79.75% <93.45%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jsumners-nr]

I don't see anything blocking, but I have a couple of questions.

[jsumners-nr]

This is a question I had when I did the initial otel research: does our infrastructure support otel's trace id format? I'm pretty sure otel's is a plain uuuidv4 sans dashes. Ours isn't:

node-newrelic/lib/util/hashes.js

Lines 87 to 115 in 8943672

	function makeId(length = 16) {
	// length is number of hex characters, which multiplied by 4 is the number of
	// bits, then divided by 8 is number of bytes. Or just divide by 2
	const numBytes = Math.ceil(length / 2)
	const randBytes = new Uint8Array(numBytes)
	// Generate random bytes one 32-bit integer at a time
	const numInts = Math.ceil(numBytes / 4) // 32 bit integers are 4 bytes
	for (let i = 0; i < numInts; i++) {
	const int = randInt32()
	const bytes = int32ToByteArray(int)
	for (let j = 0; j < 4; j++) {
	// This could "overflow" since we're iterating over the number of ints, which could
	// be more data than needed. But out-of-bound index assignment on typed arrays are
	// discarded
	randBytes[i * 4 + j] = bytes[j]
	}
	}
	// Convert the byte array to a hex string
	let id = ''
	for (let i = 0; i < randBytes.length; i++) {
	id += byteToHex[randBytes[i]]
	}
	// For odd number lengths, we may get an extra character since byteToHex returns two
	// characters, so trim to the desired length.
	return id.substring(0, length)
	}

[bizob2828]

It doesn't have an issue. I've tested this branch on apps and its linking 2 entities and the trace id from otel is on all spans