Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactored otel attribute reconciling #2964

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2961.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (258ad7d) to head (38c8ead).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
- Coverage   97.45%   97.41%   -0.04%     
==========================================
  Files         318      321       +3     
  Lines       48812    48933     +121     
==========================================
+ Hits        47568    47667      +99     
- Misses       1244     1266      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 72.19% <17.26%> (-0.09%) ⬇️
integration-tests-cjs-20.x 72.19% <17.26%> (-0.09%) ⬇️
integration-tests-cjs-22.x 72.41% <17.98%> (-0.09%) ⬇️
integration-tests-esm-18.x 49.92% <17.26%> (-0.04%) ⬇️
integration-tests-esm-20.x 49.93% <17.26%> (-0.04%) ⬇️
integration-tests-esm-22.x 49.98% <17.98%> (-0.04%) ⬇️
unit-tests-18.x 89.10% <30.21%> (+0.06%) ⬆️
unit-tests-20.x 89.10% <30.21%> (+0.06%) ⬆️
unit-tests-22.x 89.10% <30.21%> (+0.06%) ⬆️
versioned-tests-18.x 79.79% <100.00%> (-0.13%) ⬇️
versioned-tests-20.x 79.79% <100.00%> (-0.13%) ⬇️
versioned-tests-22.x 79.80% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review February 26, 2025 20:19
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. LGTM

@jsumners-nr jsumners-nr merged commit 1b5ed2c into newrelic:main Feb 27, 2025
28 of 29 checks passed
@jsumners-nr jsumners-nr deleted the issue-2961 branch February 27, 2025 17:59
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Refactor span attribute reconciling
2 participants