Skip to content

Commit

Permalink
include "nolock" in total disk space query (#93)
Browse files Browse the repository at this point in the history
Co-authored-by: Alvaro Cabanas <acabanas@newrelic.com>
  • Loading branch information
sigilioso and alvarocabanas authored Aug 17, 2022
1 parent f1643b0 commit ff77f3d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 2.8.3 (2022-08-17)
### Changed
- Improve error handling and debug logs for custom queries
- Avoid potential deadlocks in disk space query

## 2.8.2 (2022-06-27)
### Changed
- Bump dependencies
Expand Down
2 changes: 1 addition & 1 deletion src/metrics/instance_metric_definitions.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ var instanceDefinitions = []*QueryDefinition{
dovs.volume_mount_point,
dovs.available_bytes available_bytes,
dovs.total_bytes total_bytes
FROM sys.master_files mf
FROM sys.master_files mf WITH (nolock)
CROSS apply sys.Dm_os_volume_stats(mf.database_id, mf.file_id) dovs
) drives`,
dataModels: &[]struct {
Expand Down

0 comments on commit ff77f3d

Please sign in to comment.