Upgrade integrations SDK (NR-302384) #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the integration test flacky? At first I thought we had this issue again somehow, but it seems to be something different |
kang-makes
force-pushed
the
kang-makes/upgrade-infra-sdk/NR-302384
branch
from
e4874dc
to
274b9b5
Compare
kang-makes
force-pushed
the
kang-makes/upgrade-infra-sdk/NR-302384
branch
2 times, most recently
from
2a9522a
to
a0eb6cf
Compare
kang-makes
force-pushed
the
kang-makes/upgrade-infra-sdk/NR-302384
branch
from
a0eb6cf
to
b40734f
Compare
No. Is the docker that is misbehaving and is aborting. As now we support a newer version because your PR allowed it, I raised the version of the Docker image to a newer one (that also works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the integrations SDK removes the need to implement a storer in all integrations and rises the maximum interval to 5 minutes (if needed)