Skip to content

Commit

Permalink
Improve URIs doc
Browse files Browse the repository at this point in the history
  • Loading branch information
varas committed Jun 19, 2019
1 parent bcd4ca7 commit 571d57e
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/main/java/org/newrelic/nrjmx/JMXFetcher.java
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,13 @@ public JMXFetcher(String hostname, int port, String uriPath, String username, St
remoteProtocol = "remote";
}

// https://stackoverflow.com/questions/42970921/what-is-http-remoting-protocol
// Official doc for remoting v3 is not available, see:
// - https://developer.jboss.org/thread/196619
// - http://jbossremoting.jboss.org/documentation/v3.html
// Some doc on URIS at:
// - https://github.com/jboss-remoting/jboss-remoting/blob/master/src/main/java/org/jboss/remoting3/EndpointImpl.java#L292-L304
// - https://stackoverflow.com/questions/42970921/what-is-http-remoting-protocol
// - http://www.mastertheboss.com/jboss-server/jboss-monitoring/using-jconsole-to-monitor-a-remote-wildfly-server
connectionString = String.format("service:jmx:%s://%s:%s%s", remoteProtocol, hostname, port, uriPath);
} else {
connectionString = String.format("service:jmx:rmi:///jndi/rmi://%s:%s/%s", hostname, port, uriPath);
Expand Down

0 comments on commit 571d57e

Please sign in to comment.