Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force returned value to be float64 #130

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

alvarocabanas
Copy link
Contributor

Description

What are you changing/fixing?

This change adds a method to require the value returned to be casted to float64

Does your Pull Request introduce breaking changes?

No

Do the users need to upgrade immediately to the new version?

No

Do you introduce new dependencies on other libraries?

No

Checklist: before you submit

  • [ x ] apply the labels that best suit the context of your Pull Request.
  • [ x ] include unit or integration testing for your changes/additions.

gojmx/types.go Show resolved Hide resolved
gojmx/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cristianciutea cristianciutea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cristianciutea cristianciutea merged commit 0b9ce66 into newrelic:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants