Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force docker@27.3.1 to fix CVE-2024-41110 #131

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kb-newrelic
Copy link
Contributor

Summary

  • Replace github.com/docker/docker v27.0.3+incompatible brought in by github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.108.0 with github.com/docker/docker v27.3.1+incompatible
  • Building docker image locally and running trivy reports issue as resolved
➜  ~ trivy image --scanners=vuln --vuln-type=os,library --severity=HIGH,CRITICAL
 --ignore-unfixed newrelic/nr-otel-collector:0.0.0-SNAPSHOT-6f99399-rc-arm64
2024-10-17T13:03:02-07:00	WARN	'--vuln-type' is deprecated. Use '--pkg-types' instead.
2024-10-17T13:03:02-07:00	INFO	[vuln] Vulnerability scanning is enabled
2024-10-17T13:03:02-07:00	INFO	Detected OS	family="alpine" version="3.18.9"
2024-10-17T13:03:02-07:00	INFO	[alpine] Detecting vulnerabilities...	os_version="3.18" repository="3.18" pkg_num=19
2024-10-17T13:03:02-07:00	INFO	Number of language-specific files	num=1
2024-10-17T13:03:02-07:00	INFO	[gobinary] Detecting vulnerabilities...

newrelic/nr-otel-collector:0.0.0-SNAPSHOT-6f99399-rc-arm64 (alpine 3.18.9)

Total: 0 (HIGH: 0, CRITICAL: 0)

Context

  • Fixing this here for now because a fix in the receiver itself might not be sufficient because it also has prometheus itself as dependency which has no fixed 0.x.x version to this day. The newest 0.54.1 of that major version still has the vulnerability, so we would need to not only upgrade the receiver but most likely also prometheus itself or do a major version bump or work with overrides which is unclear if that is even an option in the contrib repo due to the technical debt it introduces. We'll make an effort to fix this upstream in the contrib repo but until we have a clear path forward, this fixes the vulnerability in NRDOT.

@kb-newrelic kb-newrelic requested review from a team and mailo-nr October 17, 2024 20:17
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kb-newrelic kb-newrelic merged commit 0e21567 into main Oct 18, 2024
7 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/fix-cve-2024-41110 branch October 18, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants