Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support skip nightly tests by distro/host #201

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Jan 27, 2025

Summary

  • Introduce per-distro test-spec.yaml to toggle nightly tests. The idea was that this could be a starting point to also incorporate features like skipping specific metrics and/or listing the metrics to test in the first place.
    • Corresponding nightly test infra is only deployed when enabled, e.g. k8s distro will not need to run on bare EC2s, so the EC2s shouldn't be deployed in the first place.
    • Skipped toggling k8s_node tests for now as both host and k8s will need to support it and when we move to testing k8s in host/gateway mode, we'll need to provide more finegrained control at which point we can incorporate skipping parts of it for the host distro
  • Incorporate distro into
    • k8s namespace to minimize interference
    • the hostname to 'namespace' data in NR

Tests

@kb-newrelic kb-newrelic requested a review from a team as a code owner January 27, 2025 20:07
@kb-newrelic kb-newrelic force-pushed the kbauer/nightly-multiple-distro branch from c4ba412 to 6b2d239 Compare January 27, 2025 20:10
@kb-newrelic kb-newrelic force-pushed the kbauer/nightly-multiple-distro branch from 6b2d239 to 3b7acf8 Compare January 27, 2025 20:17
@kb-newrelic kb-newrelic force-pushed the kbauer/nightly-multiple-distro branch from 3b7acf8 to ede797c Compare January 27, 2025 20:22
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit 5f96ca6 into main Jan 28, 2025
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/nightly-multiple-distro branch January 28, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants