Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nrdot-collector-host distro #202

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kb-newrelic
Copy link
Contributor

Summary

  • Moved agent config to nr-otel-collector and adjusted Dockerfile accordingly
    • Moved common README-like comments from config to (common) README in distributions to avoid having to repeat it in each config
    • Removed comment about keeping in sync with example repo and created NR-363043 to come up with a more stable process when we have multiple distros
  • Copied nr-otel-collector distro and made the following changes
    • replace all occurences of nr-otel-collector with nrdot-collector-host
    • Adjusted manifest to only include necessary/agreed-upon components and regenerated THIRD_PARTY_NOTICES.md
    • delete upload-schema-* instead of adjusting them as we won't need them until we migrated to our new publish process

@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch from 743f13d to 3348915 Compare January 28, 2025 16:16
@@ -1,6 +1,6 @@
locals {
distros = toset(distinct(flatten([
for _, v in fileset(path.module, "../../../distributions/**") :
for _, v in fileset(path.module, "../../../distributions/*/**") :
Copy link
Contributor Author

@kb-newrelic kb-newrelic Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude README from fileset to avoid regex failing.
Note: If other parts of CI fail cause the assumption of only distro folders under distributions is violated and it's too complicated to fix, we can move the contents of the README somewhere else.

@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch 3 times, most recently from d00f0f4 to 15dded0 Compare January 28, 2025 20:32
@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch from 15dded0 to 7306f93 Compare January 28, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant