Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix EC2 install script #204

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kb-newrelic
Copy link
Contributor

Summary

  • Downloading deb package from S3 on EC2s fails as latest_deb_package_filename expression also matches the checksum files and files from older versions. Adding a $ anchor filters out the checksum/signature files and head filters out older versions.
  • Also added a grep for the collector distro as that will also result in non-unique results

@kb-newrelic kb-newrelic requested a review from a team as a code owner January 28, 2025 23:30
@kb-newrelic kb-newrelic force-pushed the kbauer/adpopt-ec2-install-script-to-multi-distro branch from f3befca to 8fa072a Compare January 28, 2025 23:31
@kb-newrelic kb-newrelic force-pushed the kbauer/adpopt-ec2-install-script-to-multi-distro branch from 8fa072a to 5350e2a Compare January 28, 2025 23:31
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit 0a15702 into main Jan 29, 2025
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/adpopt-ec2-install-script-to-multi-distro branch January 29, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants