Skip to content

Commit

Permalink
removed unused props
Browse files Browse the repository at this point in the history
  • Loading branch information
times-tools committed Jan 7, 2025
1 parent aa61a37 commit 3371a35
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 19 deletions.
7 changes: 2 additions & 5 deletions packages/article-extras/src/article-extras.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ const ArticleExtras = ({
isCommentEnabled,
storefrontConfig,
breadcrumbs,
domainSpecificUrl,
isEntitlementFeatureEnabled
domainSpecificUrl
}) => {
const renderBreadcrumb = ({ showBorder } = { showBorder: false }) => {
if (breadcrumbs && breadcrumbs.length > 0) {
Expand Down Expand Up @@ -150,7 +149,6 @@ const ArticleExtras = ({
isCommentEnabled={isCommentEnabled}
storefrontConfig={storefrontConfig}
domainSpecificUrl={domainSpecificUrl}
isEntitlementFeatureEnabled={isEntitlementFeatureEnabled}
/>
</UserState>
);
Expand All @@ -177,8 +175,7 @@ ArticleExtras.propTypes = {
isCommentEnabled: PropTypes.bool,
storefrontConfig: PropTypes.string.isRequired,
breadcrumbs: PropTypes.arrayOf(PropTypes.shape({})),
domainSpecificUrl: PropTypes.string.isRequired,
isEntitlementFeatureEnabled: PropTypes.bool.isRequired
domainSpecificUrl: PropTypes.string.isRequired
};

ArticleExtras.defaultProps = {
Expand Down
4 changes: 1 addition & 3 deletions packages/article-skeleton/src/article-skeleton.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ const ArticleSkeleton = ({
publishedTime,
isSavingEnabled,
isSharingEnabled,
isCommentEnabled,
isEntitlementFeatureEnabled
isCommentEnabled
} = article;

const [showVerifyEmailBanner, setShowEmailVerifyBanner] = useState(false);
Expand Down Expand Up @@ -452,7 +451,6 @@ const ArticleSkeleton = ({
storefrontConfig={storefrontConfig}
breadcrumbs={breadcrumbs}
domainSpecificUrl={domainSpecificUrl}
isEntitlementFeatureEnabled={isEntitlementFeatureEnabled}
/>
)}
</LazyLoad>
Expand Down
6 changes: 2 additions & 4 deletions packages/ssr/src/client/article.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ if (window.nuk && window.nuk.ssr && window.nuk.article) {
sharingSavingFlag = true,
commentingFlag = true,
showAudioPlayer,
storefrontConfig,
isEntitlementFeatureEnabled
storefrontConfig
} = window.nuk.article;

const { getCookieValue } = window.nuk;
Expand All @@ -42,8 +41,7 @@ if (window.nuk && window.nuk.ssr && window.nuk.article) {
sharingSavingFlag,
commentingFlag,
showAudioPlayer,
storefrontConfig,
isEntitlementFeatureEnabled
storefrontConfig
};

const clientOptions = {
Expand Down
4 changes: 1 addition & 3 deletions packages/ssr/src/component/article.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ module.exports = (client, analyticsStream, data, helmetContext) => {
sharingSavingFlag,
commentingFlag,
showAudioPlayer,
storefrontConfig,
isEntitlementFeatureEnabled
storefrontConfig
} = data;

return React.createElement(
Expand Down Expand Up @@ -87,7 +86,6 @@ module.exports = (client, analyticsStream, data, helmetContext) => {
isSavingEnabled: sharingSavingFlag,
isSharingEnabled: sharingSavingFlag,
isCommentEnabled: commentingFlag,
isEntitlementFeatureEnabled,
isPreview
},
error,
Expand Down
6 changes: 2 additions & 4 deletions packages/ssr/src/server/article.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ module.exports = (
sharingSavingFlag = true,
commentingFlag = true,
showAudioPlayer,
storefrontConfig,
isEntitlementFeatureEnabled = false
storefrontConfig
},
userState
) => {
Expand Down Expand Up @@ -85,8 +84,7 @@ module.exports = (
sharingSavingFlag,
commentingFlag,
showAudioPlayer,
storefrontConfig,
isEntitlementFeatureEnabled
storefrontConfig
},
name: "article"
};
Expand Down

0 comments on commit 3371a35

Please sign in to comment.